Use ps_imageslider options with Bootstrap slider#920
Merged
Touxten merged 2 commits intoPrestaShop:developfrom Feb 2, 2026
Merged
Use ps_imageslider options with Bootstrap slider#920Touxten merged 2 commits intoPrestaShop:developfrom
Touxten merged 2 commits intoPrestaShop:developfrom
Conversation
Contributor
tblivet
commented
Jan 30, 2026
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Use ps_imageslider options with Bootstrap slider |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | -- |
| Sponsor company | @PrestaShopCorp |
| How to test? | Test the slider with the available options |
ga-devfront
requested changes
Jan 30, 2026
| <div class="carousel-inner" role="list" aria-label="{l s='Carousel container' d='Shop.Theme.Global'}"> | ||
| {foreach from=$homeslider.slides item=slide name='homeslider'} | ||
| <div class="carousel-item {if $slide@first} active{/if}" role="listitem"> | ||
| <div class="carousel-item {if $slide@first} active{/if}" role="listitem"{if $homeslider.speed > 0} data-bs-interval="{$homeslider.speed}"{/if}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <div class="carousel-item {if $slide@first} active{/if}" role="listitem"{if $homeslider.speed > 0} data-bs-interval="{$homeslider.speed}"{/if}> | |
| <div class="carousel-item{if $slide@first} active{/if}" role="listitem"{if $homeslider.speed > 0} data-bs-interval="{$homeslider.speed}"{/if}> |
| <div | ||
| id="ps_imageslider" | ||
| class="carousel slide" | ||
| {if $homeslider.speed > 0} data-bs-ride="carousel"{/if} |
Contributor
There was a problem hiding this comment.
Suggested change
| {if $homeslider.speed > 0} data-bs-ride="carousel"{/if} | |
| {if $homeslider.speed > 0}data-bs-ride="carousel"{/if} |
| id="ps_imageslider" | ||
| class="carousel slide" | ||
| {if $homeslider.speed > 0} data-bs-ride="carousel"{/if} | ||
| {if $homeslider.pause !== "hover"} data-bs-pause="false"{/if} |
Contributor
There was a problem hiding this comment.
Suggested change
| {if $homeslider.pause !== "hover"} data-bs-pause="false"{/if} | |
| {if $homeslider.pause !== "hover"}data-bs-pause="false"{/if} |
| class="carousel slide" | ||
| {if $homeslider.speed > 0} data-bs-ride="carousel"{/if} | ||
| {if $homeslider.pause !== "hover"} data-bs-pause="false"{/if} | ||
| {if $homeslider.wrap === "false"} data-bs-wrap="false"{/if} |
Contributor
There was a problem hiding this comment.
Suggested change
| {if $homeslider.wrap === "false"} data-bs-wrap="false"{/if} | |
| {if $homeslider.wrap === "false"}data-bs-wrap="false"{/if} |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.