Refactor quantity inputs following recent CORE changes#926
Merged
Hlavtox merged 1 commit intoPrestaShop:developfrom Feb 6, 2026
Merged
Conversation
Hlavtox
reviewed
Feb 4, 2026
| attributes=[ | ||
| "id" => "quantity_wanted_{$product.id_product}", | ||
| "value" => "{$product.quantity_required}", | ||
| "value" => "{$product.quantity_wanted}", |
Contributor
There was a problem hiding this comment.
This will never work anyway, it will always resolve to quantity_required.
Before PrestaShop/PrestaShop#40570, it wasn't even reliable, that's why I just used quantity_required.
Hlavtox
approved these changes
Feb 4, 2026
Contributor
Hlavtox
left a comment
Hlavtox
left a comment
There was a problem hiding this comment.
Works perfectly, even quantity wanted from URL works now.
AureRita
approved these changes
Feb 6, 2026
AureRita
left a comment
AureRita
left a comment
There was a problem hiding this comment.
Hi @
Thank you for your PR, I tested it and it seems to works as you can see :
Capture.video.du.2026-02-06.11-37-23.mp4
Capture.video.du.2026-02-06.11-38-49.mp4
Capture.video.du.2026-02-06.11-41-27.mp4
Because the PR seems to works as expected, It's QA ✔️
Thank you
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.