Skip to content

Fix duplicate breadcrumb block declaration in partial#940

Merged
tblivet merged 2 commits intoPrestaShop:2.xfrom
Codencode:fix/breadcrumb-block-inheritance
Feb 24, 2026
Merged

Fix duplicate breadcrumb block declaration in partial#940
tblivet merged 2 commits intoPrestaShop:2.xfrom
Codencode:fix/breadcrumb-block-inheritance

Conversation

@Codencode
Copy link
Contributor

@Codencode Codencode commented Feb 23, 2026

Questions Answers
Description? This PR fixes the breadcrumb block structure to avoid declaring the same {block name='breadcrumb'} in both layout-both-columns.tpl and breadcrumb.tpl.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company Codencode snc
How to test?

@Codencode Codencode requested a review from tblivet February 23, 2026 16:12
@Codencode Codencode changed the base branch from develop to 2.x February 23, 2026 16:13
tblivet
tblivet previously approved these changes Feb 23, 2026
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Feb 23, 2026
@tblivet tblivet added this to the v2.0.1 milestone Feb 23, 2026
@Codencode Codencode requested a review from tblivet February 24, 2026 08:07
Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Codencode, that’s good 👍 Just a small naming change regarding my suggestion: I don’t think _wrapper is needed.

@Codencode Codencode force-pushed the fix/breadcrumb-block-inheritance branch from f5f8ac6 to ab8f113 Compare February 24, 2026 08:21
@Codencode Codencode requested a review from tblivet February 24, 2026 08:21
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Feb 24, 2026
@ingridusta ingridusta self-assigned this Feb 24, 2026
Copy link

@ingridusta ingridusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Codencode,

No regression detected on the breadcrumb with ur pr.

Image

It's QA approved !

@tblivet
Copy link
Contributor

tblivet commented Feb 24, 2026

Thank you @Codencode & @ingridusta 🙏

@tblivet tblivet merged commit e43db8a into PrestaShop:2.x Feb 24, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Feb 24, 2026
@Codencode Codencode deleted the fix/breadcrumb-block-inheritance branch February 24, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants