Added support for ReScript

[vmarcosp]

Added support for ReScript

[github-actions]

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +815 B (+16.1%).

Details

file	master	pull	size diff	% diff
components/prism-rescript.min.js	0 Bytes	803 B	+803 B	+100.0%
plugins/autoloader/prism-autoloader.min.js	2.4 KB	2.41 KB	+6 B	+0.2%
plugins/show-language/prism-show-language.min.js	2.67 KB	2.67 KB	+6 B	+0.2%

Generated by 🚫 dangerJS against 3bd9b37

[fdaciuk]

🎉

[RunDevelopment]

Thank you for the PR @vmarcosp!

I gave the language a quick review and found a few things.

[vmarcosp]

@RunDevelopment some tests are broken, I'll fix and ping you back soon.

[fakenickels]

🔥🔥🔥

[RunDevelopment]

I'll be fix and ping you back soon

Take your time. I'm currently reading through the docs, so I'll probably add a few more comments.

[RunDevelopment]

Could we also add support for ReScript's char syntax? It could be done like this:

'comment': /.../,
'char': { pattern: /'.'/, greedy: true },
// ...

Also, chars seem to be heavily discouraged in the docs. Will this be removed eventually? The syntax does seem to somewhat overlap with generics.

[vmarcosp]

Could we also add support for ReScript's char syntax? It could be done like this:

'comment': /.../,
'char': { pattern: /'.'/, greedy: true },
// ...

Also, chars seem to be heavily discouraged in the docs. Will this be removed eventually? The syntax does seem to somewhat overlap with generics.

Looks nice, I'll add.
Probably will be removed in the future, but since it's simple, I can add.

[RunDevelopment]

Another nice feature would be to highlight boolean literals. Please add 'boolean': /\b(?:false|true)\b/ after number.

[RunDevelopment]

I have a question about regexes. Is %re("/b/g") special syntax, or is %re just a weird function name?

[vmarcosp]

I have a question about regexes. Is %re("/b/g") special syntax, or is %re just a weird function name?

%re Is a ppx, but we can highlight this one as a function.

[RunDevelopment]

Are all PPX of the form %name? If so, then we could highlight all of them as a function (or similar).

[vmarcosp]

Are all PPX of the form %name? If so, then we could highlight all of them as a function (or similar).

There are three forms of ppx:

• @ like @react.component - This one I'm highlighting as a class-name because it behaves like a decorator
• %% like %%raw - This one we can highlight as a function because it behaves very similar to a function.
• % like %re - The same as %%

[RunDevelopment]

There are three forms of ppx:

• @ like @react.component - This one I'm highlighting as a class-name because it behaves like a decorator
• %% like %%raw - This one we can highlight as a function because it behaves very similar to a function.
• % like %re - The same as %%

Sounds good. Then let's highlight %%name and %name as functions.

[RunDevelopment]

The coverage CI test is currently failing because:

1. The token attr-value is completely untested. Please add a test for this.
2. Not all keywords are tested. Please add a keyword test. Example.

[vmarcosp]

The coverage CI test is currently failing because:

1. The token attr-value is completely untested. Please add a test for this.
2. Not all keywords are tested. Please add a keyword test. Example.

I'm running the tests locally just to make sure that everything is passing

[RunDevelopment]

I'm running the tests locally just to make sure that everything is passing

Some parts of the CI aren't part of npm test. Coverage (npm run regex-coverage) is one of them.

[RunDevelopment]

Thank you, @vmarcosp! I think the language is ready to go. Please run npm run build to make the CI and then I'll merge this.

[vmarcosp]

Thank you, @vmarcosp! I think the language is ready to go. Please run npm run build to make the CI and then I'll merge this.

Thanks for your help 😄

[vmarcosp]

@RunDevelopment is there an estimate for the next release that includes these changes?

[RunDevelopment]

Probably this weekend.

[vmarcosp]

Oh, great! Tks

[vmarcosp]

I almost forgot, but since this pr is merged I think you can close this issue #3094