fix(home): make first-run feed peek reachable#295
Merged
Conversation
The first-run overview (#294) gated on `boardPeek.length === 0`, but the overview's "Latest on your board" peek renders only when posts exist — so the peek could never show: the moment a post existed, isNewUser flipped false and the overview disappeared. Base "new user" on discovery state instead: hasn't joined an event yet (`signedUpEvents.length === 0`), independent of posts. Now a member who has joined no events still sees the tour + their center + a live peek of their board's activity, and it self-resolves once they RSVP. Returning members with joined events keep the normal home (which carries its own #293 boards peek). Verified on web: seeded a post on the local center board and confirmed the peek renders inside the overview. frontend tests: 187 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #294.
The first-run overview gated
isNewUseronboardPeek.length === 0, but the overview's "Latest on your board" peek only renders when posts exist. Net result: the peek was dead code — the instant a post existed,isNewUserwent false and the whole overview disappeared (showing the normal home's boards section instead).Fix: define "new user" by discovery state — hasn't joined an event yet (
signedUpEvents.length === 0), independent of posts. Now a member with no joined events sees the tour + their center + a live peek of their board, and it self-resolves once they RSVP. Members with joined events keep the normal home (which has its own #293 boards peek).Verification: seeded a post on the local center board (local D1,
--local— no prod/preview writes) and confirmed the peek renders inside the overview.npm run test:frontend→ 187 pass.🤖 Generated with Claude Code