[codex] Gate guest RSVP visibility#514
Closed
KishParikh13 wants to merge 1 commit into
Closed
Conversation
Deploying chinmaya-janata with
|
| Latest commit: |
0149a8f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c619d317.project-janatha.pages.dev |
| Branch Preview URL: | https://codex-guest-rsvp-visibility.project-janatha.pages.dev |
Collaborator
Author
|
Implemented on v2 with a cleaner model that preserves the shipped #505/#504 privacy design: the public attendee COUNT now includes guest RSVPs (accurate 'X going', no PII), and the attendee LIST (/getEventUsers) is gated to logged-in attendees/creator/admin. See the commit on v2. Closing this draft in favor of that. |
KishParikh13
added a commit
that referenced
this pull request
Jun 17, 2026
Resolves #514's intent without reversing the #505/#504 privacy model: - Public attendee COUNT (people_attending) now = account attendees + non-upgraded guest RSVPs, via a shared recomputeAttendeeCount() called from addEventAttendee/removeEventAttendee/upgradeGuestRsvps/createGuestRsvp. So "X going" stays accurate including guests — no PII, just a number. - /getEventUsers (the WHO list) is now gated: authMiddleware (401) + must be an attendee, the creator, or an admin (else 403). Still PII-free; the separate gated /events/:id/roster remains the emails+guests view. - Frontend useEventDetail: count comes from the event's peopleAttending (not the account-list length); a gated list no longer errors the screen; RSVP toggles the count optimistically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Account-less RSVPs were saved but not visible to organizers. They should be reviewable by admins and visible to people who are legitimately part of the event, without leaking guest attendance through public event cards, counts, or avatar stacks.
Validation