fix(events): move attendee roster into the edit form (web + native)#525
Merged
Conversation
The "Manage attendees" roster (full list + emails/guests + CSV export) showed on the event detail view, gated by canEdit/canManage. But the detail view already lists attendees, so the roster was redundant there — and on localhost the admin gate is force-true, so it surfaced "You do not have access to this roster" to non-editors. Move it into the EDIT form (edit-existing only) on both web and native: - Remove from [id].tsx, [id].web.tsx, and both layouts in EventDetailPanel.web.tsx. - Add to form.tsx, form.web.tsx, EventFormPanel.web.tsx, gated `isEdit && eventId`. Only editors reach the edit form, so the roster is naturally editor-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying chinmaya-janata with
|
| Latest commit: |
54a818b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9db93ea4.project-janatha.pages.dev |
| Branch Preview URL: | https://fix-attendees-roster-edit-on.project-janatha.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Manage attendees" roster card showed on the event detail view. The detail view already shows the attendee list, making the roster redundant there — and because localhost force-trues the admin gate, non-editors saw a "You do not have access to this roster" card.
Change
Move the roster (full list + emails/guests + CSV export) out of the detail view and into the event edit form, shown only when editing an existing event. Only editors can reach the edit form, so it's naturally editor-only.
Removed from detail views:
app/events/[id].tsx(native),app/events/[id].web.tsx(web full-page),components/events/EventDetailPanel.web.tsx(Explore split-view, both layouts).Added to edit forms (
{isEdit && eventId}):app/events/form.tsx(native),app/events/form.web.tsx(web full-page),components/events/EventFormPanel.web.tsx(Explore split-view).Verify
tsc --noEmitclean.