Enhance ExtractDataKeyFromMetaKeyd to work with MetaTensor#8424
Open
AdamaSorho wants to merge 3 commits intoProject-MONAI:devfrom
Open
Enhance ExtractDataKeyFromMetaKeyd to work with MetaTensor#8424AdamaSorho wants to merge 3 commits intoProject-MONAI:devfrom
AdamaSorho wants to merge 3 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Adama Sorho <djomantcha@gmail.com>
ericspod
reviewed
Apr 22, 2025
Comment on lines
+63
to
+69
|
|
||
| if isinstance(d[self.meta_key], MetaTensor): | ||
| # meta tensor | ||
| meta = d[self.meta_key].meta | ||
| else: | ||
| # meta dict | ||
| meta = d[self.meta_key] |
Member
There was a problem hiding this comment.
Suggested change
| if isinstance(d[self.meta_key], MetaTensor): | |
| # meta tensor | |
| meta = d[self.meta_key].meta | |
| else: | |
| # meta dict | |
| meta = d[self.meta_key] | |
| meta: dict[str, Any] | |
| if isinstance(d[self.meta_key], MetaTensor): | |
| # meta tensor | |
| meta = d[self.meta_key].meta # type: ignore | |
| else: | |
| # meta dict | |
| meta = d[self.meta_key] |
This might be needed to get around the type issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7562 .
Description
This pull request improves
ExtractDataKeyFromMetaKey, enabling it to extract keys from aMetaTensor.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.