giveitem error on item dropdown list

[MonsterOnIV]

Describe the bug

When selecting the item dropdown list the resource freezes with the following error in the F8 log (nothing appears in server log or live console):

ps-adminmenu:nui Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'toLowerCase') (@ps-adminmenu/html/index.js:6)

To Reproduce
Steps to reproduce the behavior:

1. Open ps-adminmenu
2. Click on 'giveitem'
3. Select the dropdown menu for items
4. Resource freezes
5. See error in F8 log

Screenshots
https://i.imgur.com/XpQqEjD.png

Additional context
Using ox_inventory on an effectively vanilla QBOX recipe.

[ThatMadCap]

Is your list of items in ox_inventory custom or are you using the "default" that comes with it?

[MonsterOnIV]

it's the default, however i think i have fixed it, I think QBCore.Shred.Items uses item names as keys but ox_inventory:Items() returns a numerically indexed array of item tables with the .name as a property. so name will be a number and v.name contains the item name.

modifying the function to this now works for me:

local function GetItems()
    local items = {}

    if Config.Inventory == "ox_inventory" then
        local ItemsData = exports.ox_inventory:Items()

        for _, v in pairs(ItemsData) do
            items[#items + 1] = {
                label = v.label or v.name,
                value = v.name
            }
        end
    else
        local ItemsData = QBCore.Shared.Items

        for name, v in pairs(ItemsData) do
            items[#items + 1] = {
                label = v.label,
                value = name
            }
        end
    end

    return items
end

https://i.imgur.com/oVb6hRH.png

[ThatMadCap]

Can you please commit this fix and send through a PR?

[MonsterOnIV]

sure :)

[MonkeyWhisper]

Thank you!