Added vaapi support - #82
Open
mardaravicius wants to merge 2 commits into
Open
Conversation
mardaravicius
commented
Aug 2, 2026
|
|
||
| println!("[Resolution:\t{}x{}]", metadata.width, metadata.height); | ||
| println!("[Encoder:\t{}]", permutation.encoder); | ||
| println!("[Encoder:\t{}]", format_encoder_label(&permutation)); |
Author
There was a problem hiding this comment.
added a way to show if benchmark is running 8bit or 10bit
mardaravicius
commented
Aug 3, 2026
| pub gpu: u8, | ||
| /// DRM render node used by VAAPI encoders | ||
| #[arg(long, value_name = "device", default_value = "/dev/dri/renderD128")] | ||
| pub vaapi_device: String, |
Author
There was a problem hiding this comment.
Maybe should have changed gpu flag to be string and pass this value there? As other encoders have similar things under linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added vaapi support for this benchmarking tool. Vaapi is a linux only library to do video hw encoding and decoding that is not vendor specific.
Tested with a new AMD 890M and very old Intel HD 4400 (only supports h264) integrated gpus under ubuntu and cachy os. Seems to be working fine.