Skip to content

disable() method of MotorSubsystem will not work for positional control. #79

@spderman3333

Description

@spderman3333

Like it says on the tin, the method right now looks like:

public final void disable() {
    isEnabled = false;
    motor.set(controlMode, 0);
}

While this would work for the other control types where 0 represents stop, it wont work for positional control, as position 0, does not mean stop, it is an actual position that the motor will likely attempt to move to.

This could lead to unexpected actions from the robot, like during auto, or testing. This bug has the potential to harm someone or break something on the robot.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions