Update PersistentConfiguration to use listeners for suppliers#141
Open
kcooney wants to merge 2 commits into
Open
Update PersistentConfiguration to use listeners for suppliers#141kcooney wants to merge 2 commits into
kcooney wants to merge 2 commits into
Conversation
kcooney
force-pushed
the
kcooney/persisted-configuration-use-listener
branch
from
a8de309 to
d0a46e9
Compare
I noticed the WPILib Preferences test uses this annotation, so trying it out to see if it reduces the crashes in the test runs.
kcooney
force-pushed
the
kcooney/persisted-configuration-use-listener
branch
from
d0a46e9 to
dc8145f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, getting preference values via a supplier does not hit network
table APIs (instead, it is just a read on an atomic object).