Skip to content

build: update peft requirement from <0.19.0,>=0.18.0 to >=0.18.0,<0.20.0 #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update peft requirement from <0.19.0,>=0.18.0 to >=0.18.0,<0.20.0 #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ dependencies = [
"jaxtyping",
# peft 0.19+ enforces torchao>=0.16 in PEFT (is_torchao_available); keep <0.19 while core torchao stays <0.16.
# https://github.com/huggingface/peft/blob/6d5a6f4f2f902dbf13d21d2661d57c3c05df1dae/src/peft/import_utils.py#L131
"peft>=0.18.0,<0.19.0",
"peft>=0.18.0,<0.20.0",
Copy link
Copy Markdown

@cursor cursor Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peft bump ignores torchao cap

Medium Severity

Widening peft to <0.20.0 allows 0.19.x, which treats torchao below 0.16 as unavailable in PEFT, while dependencies still cap torchao below 0.16. The comment still says to keep peft below 0.19 for that reason but was not updated.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 227ef6d. Configure here.

"trl<=0.21.0",
"termcolor==2.3.0",
]
Expand Down
Loading