Convert C1P60 & C1P61 - #14
Merged
Merged
Conversation
review c1p60, check syntax and playthrough on the browser itself Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
cm8263
requested changes
Mar 21, 2023
cm8263
left a comment
cm8263
left a comment
Member
There was a problem hiding this comment.
Really well done for a first stab at it, let me know if you have any questions or comments on anything I wrote 👍👍
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
Co-authored-by: Christopher <10535902+cm8263@users.noreply.github.com> Signed-off-by: Chase Rimmer <126846200+chaserimmer@users.noreply.github.com>
chaserimmer
commented
Mar 24, 2023
chaserimmer
left a comment
chaserimmer
left a comment
Contributor
Author
There was a problem hiding this comment.
implemented changes requested.
cm8263
marked this pull request as ready for review
April 12, 2023 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review c1p60, check syntax and playthrough on the browser itself