Jax hot fix#273
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Jax compatibility issues in the autogalaxy codebase related to mass profile calculations and linear light profile intensity handling.
Changes:
- Added
xpparameter propagation todeflections_yx_2d_frommethod inBasisclass for Jax array backend compatibility - Added explicit float conversion for reconstruction values extracted from inversions to ensure Python native float type
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| autogalaxy/profiles/basis.py | Passes the xp parameter to mass profile deflections calculations, enabling Jax array backend support |
| autogalaxy/abstract_fit.py | Converts reconstruction array elements to Python float type for dictionary storage, ensuring compatibility with Jax arrays |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jax fix for the use of mass_light_dark.