fix: cNFWSph deflection boundary bug and MCR validation (#451)#454
Merged
Conversation
Fix F_func boundary condition: theta == scale_radius fell through both branches (strict < and >) leaving F=0, producing wildly wrong deflections at that exact radius (e.g. -0.708 instead of +0.319). Changed to <=. Add runtime warning + clamp when Penarrubia 2012 MCR integral factor is non-positive (f_c > ~0.18 for typical concentrations), which caused kappa_s to diverge/go negative and deflections to flip sign. Fixes #451. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in the cored NFW profile reported in #451:
F_func boundary condition:
cNFWSph.F_funcused strict</>masks, sotheta == scale_radiusfell through both branches and returned zero — producing wildly wrong deflections at that exact radius. Changed to<=.Peñarrubia MCR integral crosses zero for large f_c: The MCR integral factor becomes non-positive at f_c > ~0.18 (typical concentrations), causing
kappa_sto diverge and go negative. Added a runtime warning and clamp to prevent NaN/Inf propagation.The third problem from #451 (convergence returning zeros) was already fixed in #449.
API Changes
None — internal bug fix. The warning for invalid f_c is new user-visible behaviour.
Test Plan
🤖 Generated with Claude Code