fix: elliptical MGE potential via deflection line integral#460
Merged
Conversation
Replace the circular E1 potential formula (which only worked for spherical profiles) with a Gauss-Legendre quadrature integration of the MGE deflection field along radial lines. This correctly handles elliptical profiles by construction — the potential is the integral of the (verified correct) MGE deflections. Sersic, SersicCore, Exponential, DevVaucouleurs, Chameleon, cNFW elliptical variants all now pass self-consistency checks (errors 1e-4 to 1e-3). Gaussian mass profile remains a known limitation (MGE decomposition of a single narrow Gaussian is inherently lossy). Fixes #459. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the circular E1 potential formula with Gauss-Legendre quadrature integration of the MGE deflection field along radial lines. The E1 formula only worked for spherical profiles; the new approach correctly handles elliptical profiles by construction. Fixes #459.
Key results (from Phase 1 self-consistency tests):
API Changes
Changed internal implementation of
MGEDecomposer.potential_2d_via_mge_from. Addedsigma_functionstatic method andn_quadparameter. No public API changes.Test Plan
pytest test_autogalaxy/profiles/mass/— 406 passed, 0 failed🤖 Generated with Claude Code