perf: vectorize MGE potential over components#461
Merged
Conversation
Replace the inner loop over MGE components with a single vectorized zeta_from call per quadrature point. Point-wise validation confirms the potential converges to 10 significant digits at n_quad=20. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vectorize the inner component loop in potential_2d_via_mge_from — one zeta_from call per quadrature point instead of n_components calls. Cleaner code, same accuracy. Point-wise validation: potential converges to 1e-9 at n_quad=20; the ~1e-4 errors in the test suite are purely finite-difference verification noise.