Feature/point redesign#334
Merged
Merged
Conversation
…2, but now produces wrong fit result?
rhayes777
approved these changes
Jan 31, 2025
Comment on lines
+65
to
+67
| self.profile = ( | ||
| tracer.extract_profile(profile_name=name) if profile is None else profile | ||
| ) |
Collaborator
There was a problem hiding this comment.
self.profile = profile or tracer.extract_profile(profile_name=name)
Collaborator
There was a problem hiding this comment.
This extract_profile stuff looks a bit whacky to me
Comment on lines
+65
to
+66
| data_position: np.array, | ||
| model_position: np.array, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to help @jhod0 begin implementing new point source function, I have done a redesign and refactor of the
pointmodule.This does the following:
Fitobject.FitPointhierarchy to be clearer.I am not overly keen on the design of the
point/fitpackage yet, with inheritance used a lot and quite confusing. But I don't have the capacity for a full redesign yet, and think we should wait until everything works with JAX before moving more stuff around.The merit of this design is that it mirrors other
Fitobjects throughout PyAutoLens, which is important for using functionality like the aggregator. It also means the API when you have a fit, e.g. after a model-fit, is quite clear and easy to use and contains everything:This should help us get started.