Skip to content

Remove universal support on the wheel#655

Merged
ericwb merged 2 commits into
PyCQA:masterfrom
ericwb:universal
Dec 7, 2020
Merged

Remove universal support on the wheel#655
ericwb merged 2 commits into
PyCQA:masterfrom
ericwb:universal

Conversation

@ericwb

@ericwb ericwb commented Dec 6, 2020

Copy link
Copy Markdown
Member

Now that Bandit is Py3 only, it should be considered a "Pure-Python
Wheel" instead of a "Universal". Further information can be found
here: https://realpython.com/python-wheels/#specifying-a-universal-wheel

Fixes #654

Signed-off-by: Eric Brown browne@vmware.com

Now that Bandit is Py3 only, it should be considered a "Pure-Python
Wheel" instead of a "Universal". Further information can be found
here: https://realpython.com/python-wheels/#specifying-a-universal-wheel

Fixes #654

Signed-off-by: Eric Brown <browne@vmware.com>
@ericwb ericwb added this to the Release 1.6.4 milestone Dec 6, 2020

@lukehinds lukehinds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will let you merge as you may have some sort of merge order in mind.

@ericwb ericwb merged commit efa623e into PyCQA:master Dec 7, 2020
@sigmavirus24

Copy link
Copy Markdown
Member

I'm 90% certain we actually want to keep this as this tells pip that this is "universal" for all versions of Python 3 we support

@sigmavirus24

Copy link
Copy Markdown
Member

PyCQA/pyflakes#597 (comment) gives me that 90% certainty and 10% uncertainty

@ericwb

ericwb commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

PyCQA/pyflakes#597 (comment) gives me that 90% certainty and 10% uncertainty

According to https://realpython.com/python-wheels/#different-types-of-wheels, this is still considered a pure python wheel, just one that doesn't support py2.

A universal wheel contains py2.py3-none-any.whl. It supports both Python 2 and Python 3 on any OS and 
platform. The majority of wheels listed on the Python Wheels website are universal wheels.

A pure-Python wheel contains either py3-none-any.whl or py2.none-any.whl. It supports either Python 3 or 
Python 2, but not both. It’s otherwise the same as a universal wheel, but it’ll be labeled with either py2 or py3 
rather than the py2.py3 label.

@sigmavirus24

Copy link
Copy Markdown
Member

Looking at https://packaging.python.org/guides/distributing-packages-using-setuptools/#pure-python-wheels you do appear to be correct. I've found enough misinformation on realpython.com to not trust it

@ericwb ericwb modified the milestones: Release 1.6.4, Release 1.7.0 Dec 13, 2020
@ericwb ericwb deleted the universal branch May 21, 2021 23:00
mikespallino pushed a commit to mikespallino/bandit that referenced this pull request Aug 25, 2021
Now that Bandit is Py3 only, it should be considered a "Pure-Python
Wheel" instead of a "Universal". Further information can be found
here: https://realpython.com/python-wheels/#specifying-a-universal-wheel

Fixes PyCQA#654

Signed-off-by: Eric Brown <browne@vmware.com>

Co-authored-by: Luke Hinds <7058938+lukehinds@users.noreply.github.com>
mikespallino pushed a commit to mikespallino/bandit that referenced this pull request Jan 7, 2022
Now that Bandit is Py3 only, it should be considered a "Pure-Python
Wheel" instead of a "Universal". Further information can be found
here: https://realpython.com/python-wheels/#specifying-a-universal-wheel

Fixes PyCQA#654

Signed-off-by: Eric Brown <browne@vmware.com>

Co-authored-by: Luke Hinds <7058938+lukehinds@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wheel artifact no longer universal

3 participants