handle #[pyo3(from_py_with = "")] in #[setter] methods#3995
Merged
Conversation
davidhewitt
approved these changes
Mar 26, 2024
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks!
I wonder if the fact that this slipped through means that there's a bigger refactoring overdue, but I'm happy to leave that for a future PR...
| }) | ||
| .unwrap_or_else(|| { | ||
| quote! { | ||
| let _val = #pyo3_path::FromPyObject::extract_bound(_value.into())?; |
Member
There was a problem hiding this comment.
I suppose here we probably want to check if _val is a GIL Ref, via holders.push_gil_refs_checker?
Member
There was a problem hiding this comment.
(Either way, I think worthy of its own PR and newsfragment, so I'll merge this PR now.)
Member
Author
There was a problem hiding this comment.
True, maybe I'll take a look at that tomorrow
|
Thanks for the quick fix @Icxolu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3992
Handle the
#[pyo3(from_py_with = "")]attribute in#[setter]methods instead of silently ignoring it.