allow constructor customization of complex enum variants

[Icxolu]

This is an (experimental) idea I had to support customization of the macro generated constructors for complex enum variants.

This allow placing the the #[pyo3(signature = ...)] attribute on complex enum variants and applies it to the generated constructor.
This way all the normal functionality of signature customization can also be applied for these generated constructors.

What I'm not completely sure about is whether we should reuse the signature name here, or whether we should have have some kind of alias like #[pyo3(constructor = ...)]. On one hand people are already familiar with how signature works, but using it on an enum variant (or anything that's not a function for that matter) is not so intuitive.

Closes #4109

[davidhewitt]

I like this idea! I'll try to review the full code tomorrow, though I have some initial thoughts about how this extends:

• it would be awesome to support something like this for #[pyclass] to automatically generate the #[new] in that case too. Is signature the right name in that case? I feel like constructor, new, or even init might be stronger choices when it's adding a function to the class?
• re signature vs constructor, the only conflict I can think of is that we might want to allow users to do something like constructor = "some_func" in cases where the auto-generated constructor isn't enough. Or maybe we should have #[new(MyVariant)] in #[pymethods] for that case, if that's technically viable?

[Icxolu]

• it would be awesome to support something like this for #[pyclass] to automatically generate the #[new] in that case too. Is signature the right name in that case?

Yeah, that came up in #4109 (comment) too. I think that extension is a good argument to go with a more descriptive keyword for that context.

• re signature vs constructor, the only conflict I can think of is that we might want to allow users to do something like constructor = "some_func"

Hmm, interesting idea. It might be pretty tricky to guarantee that the correct variant is constructed if we open this for users.

[davidhewitt]

• re signature vs constructor, the only conflict I can think of is that we might want to allow users to do something like constructor = "some_func"

Hmm, interesting idea. It might be pretty tricky to guarantee that the correct variant is constructed if we open this for users.

Ah, very true, I guess we probably cannot, which is a good reason not to add that. And they can always add their own #[staticmethod] or #[classmethod] which constructs the variants anyway.

[davidhewitt]

This looks good to me! 👍

Just a few small suggestions, and this also needs documentation before it can be merged.

[Icxolu]

I've added to the complex enum section of the guide and put the attribute in the pyclass options table. Is there any other place where we want to mention this?

[davidhewitt]

I think that's sufficient for now, thanks!

[davidhewitt]

I think this collect can be made infallible again.

[Icxolu]

Ah, yes. I reverted it to how it was before 👍

[EricLBuehler]

@davidhewitt, @Icxolu thank you for implementing this!