ci: run coverage for the free-threaded build#4638
Conversation
davidhewitt
force-pushed
the
free-threaded-coverage
branch
from
d17cdd6 to
24ef718
Compare
CodSpeed Performance ReportMerging #4638 will degrade performances by 12.48%Comparing Summary
Benchmarks breakdown
|
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
This looks like it's worked; I'm going to merge it so that it's available for the other in-flight freethreaded PRs. Will revert / amend if there are concerns.
| # This runs as a separate job because it needs to run on the `pull_request_target` event | ||
| # in order to access the CODECOV_TOKEN secret. | ||
| # | ||
| # This is safe because this doesn't run arbitrary code from PRs. | ||
|
|
||
| name: Set Codecov PR base | ||
| on: | ||
| # See safety note / doc at the top of this file. | ||
| pull_request_target: |
There was a problem hiding this comment.
cc @alex, I believe this use of pull_request_target to be safe (unlike my last time 🙈), but if you disagree, please ping and I'll revert!
There was a problem hiding this comment.
As long as this doesn't run code from the PR, and only runs code from main/this .yml, it's fine. That looks true here.
There was a problem hiding this comment.
Yep that was my understanding too 👍
|
Thanks David! It'll be nice to have coverage reports on PRs for Py_GIL_DISABLED blocks. |
|
Over on #4588 I'm seeing the coverage tests failing with a git error: |
3 participants
This is loosely related to #4635.
From what I've worked out experimenting with those PRs, I realise that we can run coverage on the merge commit in CI. The nice thing about this is that we can add all jobs (not just
build) to coverage.Most importantly for current work, this enables code coverage for the freethreaded job. cc @ngoldbaum