Add example Cargo.toml and build.rs for exposing pyo3 cfgs#4641
Merged
Conversation
ngoldbaum
force-pushed
the
clarify-build-config-docs
branch
from
7257e24 to
13f8c21
Compare
davidhewitt
approved these changes
Oct 24, 2024
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks - we do have this in the guide at https://pyo3.rs/v0.22.5/building-and-distribution/multiple-python-versions but it never hurts to add it multiple times :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #4588 I ran into this documentation snippet and it would have saved me some time if the docs explicitly spelled out what you need to do.