migrate call API to IntoPyObject#4653
Merged
Merged
Conversation
This was referenced Oct 25, 2024
CodSpeed Performance ReportMerging #4653 will degrade performances by 36.12%Comparing Summary
Benchmarks breakdown
|
davidhewitt
approved these changes
Oct 26, 2024
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Yes agreed, it's a shame to lose the performance but I think given the greater need is (in my opinion) to get 0.23 shipped, let's create an issue with a note to this PR both to remind ourselves of this follow-up and also so it's easy for us to find the code we removed.
Member
Author
|
I opened #4656 to track this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the Python
callAPIs to useIntoPyObjectfor their arguments. For simplicity this removes removes the vectorcall specialization for now. Hopefully we can bring it back with aPyCallArgstrait as discussed in #4456 (comment) in 0.24