move IntoPy::type_output to IntoPyObject::type_output#4657
Merged
Conversation
Member
Author
|
Not really sure why MSRV needs the additional lifetime bounds, but they should be implied anyway, so spelling them out should not really be a problem either. |
This was referenced Oct 26, 2024
davidhewitt
approved these changes
Oct 26, 2024
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Agreed, this is fine to do in my opinion. Weird about those inferred lifetimes, I guess we live with them for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4618
This moves
IntoPy::type_outputtoIntoPyObject::type_output. This is a breaking change, but this is an experimantel feature and the ergonomics of duplicating the API is pretty bad, because it would need fully qualified syntax on the callsite to determine the trait to use.