fixup docs for packaging#4710
Merged
Merged
Conversation
davidhewitt
commented
Nov 15, 2024
Member
Author
There was a problem hiding this comment.
Content here had gone stale so I updated it (by copy-paste).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging failed for
pyo3-ffiin the release just now, because we had aninclude_str!("../examples/string-sum/src/lib.rs").I couldn't find a way to include the example in the package (cargo seems to force exclude it as a subpackage), so I inlined it into
pyo3-ffi/src/lib.rs.At the same time I spotted a couple of other README issues so updated them.
Will merge as trivial and get on with releasing.