Do not use static type references when compiling for RustPython#5995
Conversation
87e669a to
391626b
Compare
391626b to
583b78d
Compare
91658f1 to
a136b15
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
| } | ||
|
|
||
| extern_libpython! { |
There was a problem hiding this comment.
There are a number of places in this PR where the extern blocks can be merged with one immediately above / below.
(I wonder if we could / should write a lint for that, maybe as part of the recently added machinery in the noxfile for formatting these?)
There was a problem hiding this comment.
I've merged most adjacent blocks where the cfg attributes where the same. Please let me know I you see an other spot that needs cleaning.
There was a problem hiding this comment.
I've moved around some some locally implemented/exported functions around to reduce even more extern_libpython blocks. Please let me know what you think.
Merge adjacent extern blocks Fixes
e8b2d31 to
05475d1
Compare
98f5fab to
7a5445f
Compare
e57a4d3 to
2582a79
Compare
|
I've also fixed all the places where |
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this seems reasonable to me
|
Thanks for reviewing this! |
Removed all usage of static type pointers when compiling for RustPython. Diff is large but is very repetitive.
Test plan
xref RustPython/RustPython#7562
https://discuss.python.org/t/c-api-add-py-getbuildintype-and-py-getbuildintypeborrowed/107010