clean up / fix outdated private API definitions#6038
Merged
Conversation
Open
davidhewitt
commented
May 12, 2026
Comment on lines
+144
to
+152
| #[cfg_attr(not(Py_3_12), link_name = "_PyCode_GetExtra")] | ||
| pub fn PyUnstable_Code_GetExtra( | ||
| code: *mut PyObject, | ||
| index: Py_ssize_t, | ||
| extra: *mut *mut c_void, | ||
| ) -> c_int; | ||
|
|
||
| #[cfg_attr(not(Py_3_12), link_name = "_PyCode_SetExtra")] | ||
| pub fn PyUnstable_Code_SetExtra( |
Member
Author
There was a problem hiding this comment.
I couldn't decide exactly the strategy to handle these renames; keeping the old name around as a deprecated symbol and exposing the new one on all versions seemed like the easiest way to give users a migration path.
ngoldbaum
approved these changes
May 25, 2026
Contributor
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
I double-checked all the FFI changes and didn't see any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5965 / #6036
This PR cleans up another batch of private FFI functions which had fallen out of date in
pyo3-ffi.