refactor: move check-cfg for private pyo3 cfgs to cargo configuration#6067
Open
davidhewitt wants to merge 1 commit into
Open
refactor: move check-cfg for private pyo3 cfgs to cargo configuration#6067davidhewitt wants to merge 1 commit into
check-cfg for private pyo3 cfgs to cargo configuration#6067davidhewitt wants to merge 1 commit into
Conversation
Icxolu
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted this while reviewing #5807
It makes the
PYO3_PRINT_CONFIGoutput slightly less verbose, and also technically is more correct as we only need these cfgs internally and not for all users ofpyo3-build-config.