internal: introduce ErrorAlreadySet marker when FFI calls return an exception#6069
Open
davidhewitt wants to merge 2 commits into
Open
internal: introduce ErrorAlreadySet marker when FFI calls return an exception#6069davidhewitt wants to merge 2 commits into
ErrorAlreadySet marker when FFI calls return an exception#6069davidhewitt wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of an experiment to add an
ErrorAlreadySet<'py>zero-sized type to denote that a Python exception has been raised in the interpreter. This avoids all the overhead ofPyErr::fetch, especially on paths where we immediately clear the error.Because many C API calls may not legally be called when there is an exception raised in the interpreter, I denote it
unsafeto create and probably all functions which may return aResult<_, ErrorAlreadySet<'_>>should beunsafetoo.I see two key advantages of this type:
#[pyfunction]into the Python interpreter, we could potentially avoid fetching aPyErr.In this PR I:
FfiPtrExtandPyResultExtinternal traitsPySetMethods::pop, where it eagerly discards the error instead of fetching it and then dropping it.IntoPyObjectsupport perhaps, see below).If the type seems promising, I'd like to experiment with using it for the
#[pyfunction]boundary. The hardest part is thatIntoPyObjectimplementations don't currently use this error type.I can either do further experimentation in this PR, or as a follow up, depending on what folks think about the potential of this type.