bug fix: remove print and logger statements#217
Merged
srijanpatel merged 2 commits intomainfrom Mar 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 444588f in 32 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. backend/pyspur/nodes/decorator.py:230
- Draft comment:
Removed debug logging and print statements. Ensure that if you need debugging in the future, consider a toggleable debug flag or proper log-level configuration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. backend/pyspur/nodes/decorator.py:230
- Draft comment:
Removed debug logging and print statements to clean up production output. If needed for troubleshooting, consider conditional logging behind a debug flag. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_Wf4j2g9QywwonUxv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
backend/pyspur/nodes/decorator.pyfile. The change removes debug logging and a print statement from therunmethod to clean up the code.backend/pyspur/nodes/decorator.py: Removed debug logging and print statement from therunmethod to clean up the code.Important
Remove debug logging and print statement from
runmethod indecorator.pyfor code cleanup.runmethod indecorator.pyto clean up the code.This description was created by
for 444588f. It will automatically update as commits are pushed.