Skip to content

fix typo: beginner_source/former_torchies/nnft_tutorial.py - #515

Merged
hyoyoung merged 1 commit into
PyTorchKR:masterfrom
95hj:master
Jul 31, 2022
Merged

fix typo: beginner_source/former_torchies/nnft_tutorial.py#515
hyoyoung merged 1 commit into
PyTorchKR:masterfrom
95hj:master

Conversation

@95hj

@95hj 95hj commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

๋ผ์ด์„ ์Šค ๋™์˜

๋ณ€๊ฒฝํ•ด์ฃผ์‹œ๋Š” ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์„ ๋™์˜ํ•ด์ฃผ์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค.

๋” ์ž์„ธํ•œ ๋‚ด์šฉ์€ ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

๋™์˜ํ•˜์‹œ๋ฉด ์•„๋ž˜ [ ]๋ฅผ [x]๋กœ ๋งŒ๋“ค์–ด์ฃผ์„ธ์š”.

  • ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ํ™•์ธํ•˜์˜€์œผ๋ฉฐ, ๋ณธ PR ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์— ๋™์˜ํ•ฉ๋‹ˆ๋‹ค.

๊ด€๋ จ ์ด์Šˆ ๋ฒˆํ˜ธ

์ด Pull Request์™€ ๊ด€๋ จ์žˆ๋Š” ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”.

์ด์Šˆ ๋˜๋Š” PR ๋ฒˆํ˜ธ ์•ž์— #์„ ๋ถ™์ด์‹œ๋ฉด ์ œ๋ชฉ์„ ๋ฐ”๋กœ ํ™•์ธํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. (์˜ˆ. #999 )

PR ์ข…๋ฅ˜

์ด PR์— ํ•ด๋‹น๋˜๋Š” ์ข…๋ฅ˜ ์•ž์˜ [ ]์„ [x]๋กœ ๋ณ€๊ฒฝํ•ด์ฃผ์„ธ์š”.

  • ์˜คํƒˆ์ž๋ฅผ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ๋ฒˆ์—ญ์„ ๊ฐœ์„ ํ•˜๋Š” ๊ธฐ์—ฌ
  • ๋ฒˆ์—ญ๋˜์ง€ ์•Š์€ ํŠœํ† ๋ฆฌ์–ผ์„ ๋ฒˆ์—ญํ•˜๋Š” ๊ธฐ์—ฌ
  • ๊ณต์‹ ํŠœํ† ๋ฆฌ์–ผ ๋‚ด์šฉ์„ ๋ฐ˜์˜ํ•˜๋Š” ๊ธฐ์—ฌ
  • ์œ„ ์ข…๋ฅ˜์— ํฌํ•จ๋˜์ง€ ์•Š๋Š” ๊ธฐ์—ฌ

PR ์„ค๋ช…

์ด PR๋กœ ๋ฌด์—‡์ด ๋‹ฌ๋ผ์ง€๋Š”์ง€ ๋Œ€๋žต์ ์œผ๋กœ ์•Œ๋ ค์ฃผ์„ธ์š”.

beginner_source/former_torchies/nnft_tutorial.py ๋ฌธ์„œ์˜ ์˜คํƒˆ์ž ๊ฒ€์‚ฌ ๋ฐ ์ˆ˜์ •์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
๋„์–ด์“ฐ๊ธฐ๊ฐ€ ์ž˜๋ชป๋˜์–ด์žˆ๋Š” ๋‘ ๋ถ€๋ถ„์„ ์ฐพ์•˜๊ณ 

  1. ๋ณด์ด๋Š”๋Œ€๋กœ-> ๋ณด์ด๋Š” ๋Œ€๋กœ
  2. ์—ฌ๋Ÿฌ๋ฒˆ -> ์—ฌ๋Ÿฌ ๋ฒˆ
    ์œผ๋กœ ์ˆ˜์ • ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค.

@95hj
95hj marked this pull request as draft July 29, 2022 11:38
@95hj
95hj marked this pull request as ready for review July 29, 2022 11:39

@2kkeullim 2kkeullim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yesulpark

Copy link
Copy Markdown
Contributor

LGTM

@hyoyoung hyoyoung added the ์ปจํŠธ๋ฆฌ๋ทฐํ†ค ์˜คํ”ˆ์†Œ์Šค ์ปจํŠธ๋ฆฌ๋ทฐํ†ค ๊ด€๋ จ ์ด์Šˆ/PR label Jul 29, 2022

@hyoyoung hyoyoung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@hyoyoung
hyoyoung merged commit 3cb8532 into PyTorchKR:master Jul 31, 2022
bub3690 pushed a commit to bub3690/tutorial_kr_myrepo that referenced this pull request Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

์ปจํŠธ๋ฆฌ๋ทฐํ†ค ์˜คํ”ˆ์†Œ์Šค ์ปจํŠธ๋ฆฌ๋ทฐํ†ค ๊ด€๋ จ ์ด์Šˆ/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants