Skip to content

Char rnn classification tutorial typo correction - #611

Merged
hyoyoung merged 6 commits into
PyTorchKR:masterfrom
garlicvread:char_rnn_classification_tutorial_typo_correction
Dec 2, 2022
Merged

Char rnn classification tutorial typo correction#611
hyoyoung merged 6 commits into
PyTorchKR:masterfrom
garlicvread:char_rnn_classification_tutorial_typo_correction

Conversation

@garlicvread

@garlicvread garlicvread commented Oct 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

๋ผ์ด์„ ์Šค ๋™์˜

  • ๊ธฐ์—ฌํ•˜๊ธฐ ๋ฌธ์„œ๋ฅผ ํ™•์ธํ•˜์˜€์œผ๋ฉฐ, ๋ณธ PR ๋‚ด์šฉ์— BSD 3ํ•ญ ๋ผ์ด์„ ์Šค๊ฐ€ ์ ์šฉ๋จ์— ๋™์˜ํ•ฉ๋‹ˆ๋‹ค.

๊ด€๋ จ ์ด์Šˆ ๋ฒˆํ˜ธ

PR ์ข…๋ฅ˜

  • ์˜คํƒˆ์ž๋ฅผ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ๋ฒˆ์—ญ์„ ๊ฐœ์„ ํ•˜๋Š” ๊ธฐ์—ฌ
  • ๋ฒˆ์—ญ๋˜์ง€ ์•Š์€ ํŠœํ† ๋ฆฌ์–ผ์„ ๋ฒˆ์—ญํ•˜๋Š” ๊ธฐ์—ฌ
  • ๊ณต์‹ ํŠœํ† ๋ฆฌ์–ผ ๋‚ด์šฉ์„ ๋ฐ˜์˜ํ•˜๋Š” ๊ธฐ์—ฌ
  • ์œ„ ์ข…๋ฅ˜์— ํฌํ•จ๋˜์ง€ ์•Š๋Š” ๊ธฐ์—ฌ

PR ์„ค๋ช…

  • ์ปจํŠธ๋ฆฌ๋ทฐํ„ฐ ์ •๋ณด ์ถ”๊ฐ€
  • ๋ˆ„๋ฝ๋œ ๋งˆ์นจํ‘œ ์ถ”๊ฐ€
    • 16, 195(beginner_source/saving_loading_models.py)
    • 535, 536, 537(intermediate_source/char_rnn_classification_tutorial.py)
  • ๋„์–ด์“ฐ๊ธฐ ๋ฐ ์กฐ์‚ฌ ์ˆ˜์ •

raymond added 6 commits October 22, 2022 15:20
raymond
saving_loading_models.py torchScript ๋ฏธ๋ฒˆ์—ญ๋ถ„ ๋ฒˆ์—ญ
7748fe7 
### Motivation
- TorchScript ๋ถ€๋ถ„ ๋ฏธ๋ฒˆ์—ญ ๋ฌธ๋‹จ

### Key Changes
- TorchScript ๋ฏธ๋ฒˆ์—ญ ๋ฌธ๋‹จ ๊ตญ๋ฌธ ๋ฒˆ์—ญ
- ์ฝ”๋“œ ์ฃผ์„ ๋ฒˆ์—ญ ์ถ”๊ฐ€

### To Reviewers
- ์˜คํ”ˆ์†Œ์Šค ์ฒซ ๊ธฐ์—ฌ๋ผ ์žฌ๋ฐŒ์Šต๋‹ˆ๋‹ค ใ…Žใ…Ž
raymond
์˜คํƒ€ ์ˆ˜์ •: Line 240, ๊ธฐ -> ์‚ญ์ œ
5af6ba3
raymond
์˜คํƒ€ ์ˆ˜์ •: Line 21, ์˜ฌ -> ์œ„์น˜ ์ˆ˜์ •
c6a7132
raymond
์ปจํŠธ๋ฆฌ๋ทฐํ„ฐ ์ •๋ณด ์ถ”๊ฐ€
9a78461
raymond
๋„์–ด์“ฐ๊ธฐ ์ˆ˜์ •
4eea1af
raymond
๋„์–ด์“ฐ๊ธฐ ๋ฐ ์˜คํƒ€ ์ˆ˜์ •
4bfea8b
@garlicvread
garlicvread marked this pull request as ready for review October 22, 2022 13:49
garlicvread
garlicvread commented Oct 22, 2022
View reviewed changes

@garlicvread garlicvread left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR์„ ์กฐ๊ธˆ ์‹ค์ˆ˜ํ•œ ๊ฒƒ ๊ฐ™์€๋ฐ, ์ˆ˜์ •ํ•ด์„œ ๋‹ค์‹œ ์ปค๋ฐ‹ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์„๊นŒ์š”?

garlicvread
garlicvread commented Oct 22, 2022
View reviewed changes

@garlicvread garlicvread left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •์™„๋ฃŒ

garlicvread
garlicvread commented Oct 22, 2022
View reviewed changes

@garlicvread garlicvread left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ • ์™„๋ฃŒ

garlicvread
garlicvread commented Oct 22, 2022
View reviewed changes

@garlicvread garlicvread left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ปจํŠธ๋ฆฌ๋ทฐํ„ฐ ์ •๋ณด ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ทธ๋Ÿฐ๋ฐ ์ด๊ฒŒ ์•„๊นŒ ์˜คํ›„์— ํ•œ ๋‚ด์šฉ์ด๋ผ ์ปค๋ฐ‹์„ ์ˆ˜์ •ํ•ด์•ผํ•˜๋‚˜ ๊ณ ๋ฏผ ์ค‘์ž…๋‹ˆ๋‹ค.

garlicvread
garlicvread commented Oct 22, 2022
View reviewed changes

@garlicvread garlicvread left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฒƒ๋„ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ ์˜คํ›„์— ํ•œ ๋‚ด์šฉ์ž…๋‹ˆ๋‹ค.

garlicvread
garlicvread commented Oct 22, 2022
View reviewed changes

@garlicvread garlicvread left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ „์ฒด์ ์œผ๋กœ ์˜คํƒ€๋Š” #457 ์ด์Šˆ์—์„œ ์ด๋ฏธ ์–ธ๊ธ‰๋œ '๋–„' ๋Š” ์ด๋ฏธ ์ˆ˜์ •์ด ๋œ ์ƒํƒœ์˜€๊ณ ,
๊ทธ ์™ธ์— '์ปค๋งจ๋“œ'๊ฐ€ '์ปค๋ฉ˜๋“œ'๋กœ ์ ํ˜€ ์žˆ๋Š” ์ผ€์ด์Šค๊ฐ€ ํ•˜๋‚˜ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.

Comment thread intermediate_source/char_rnn_classification_tutorial.py
`torchtext` ์˜ ํŽธ๋ฆฌํ•œ ๋งŽ์€ ๊ธฐ๋Šฅ๋“ค์„ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ณ  ์–ด๋–ป๊ฒŒ ํ•˜๋Š”์ง€ "๊ธฐ์ดˆ๋ถ€ํ„ฐ(from scratch)"
๋ณด์—ฌ์ฃผ๊ธฐ ๋•Œ๋ฌธ์— NLP ๋ชจ๋ธ๋ง์„ ์œ„ํ•œ ์ „์ฒ˜๋ฆฌ๊ฐ€ ์ €์ˆ˜์ค€์—์„œ ์–ด๋–ป๊ฒŒ ์ง„ํ–‰๋˜๋Š”์ง€๋ฅผ ์•Œ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๋‹จ์–ด๋ฅผ ๋ถ„๋ฅ˜ํ•˜๊ธฐ ์œ„ํ•ด ๊ธฐ์ดˆ์ ์ธ ๋ฌธ์ž-๋‹จ์œ„ RNN์„ ๊ตฌ์ถ•ํ•˜๊ณ  ํ•™์Šตํ•  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค.
์ด ํŠœํ† ๋ฆฌ์–ผ์—์„œ๋Š”(์ดํ›„ 2๊ฐœ ํŠœํ† ๋ฆฌ์–ผ๊ณผ ํ•จ๊ป˜) NLP ๋ชจ๋ธ๋ง์„ ์œ„ํ•ด `torchtext` ์˜

@garlicvread garlicvread Oct 22, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์–ด์ƒ‰ํ•œ ๋ฒˆ์—ญ์ฒด๋ฅผ ์šฐ๋ฆฌ๋ง ๋ฌธ๋ฒ•์— ๋งž๊ฒŒ ๋ฌธ์žฅ ๊ตฌ์กฐ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

hyoyoung
hyoyoung approved these changes Dec 2, 2022
View reviewed changes

@hyoyoung hyoyoung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค์Œ๋ถ€ํ„ฐ๋Š” ๊ฐœ๋ณ„ ํŒŒ์ผ๋ณ„๋กœ, ๋ณ„๋„์˜ PR๋กœ ์ œ์ถœ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค

good

@hyoyoung
hyoyoung merged commit 82e1040 into PyTorchKR:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyoyoung hyoyoung hyoyoung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garlicvread @hyoyoung