Make flake8-bugbear happy#35
Open
kpinc wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8-bugbear declares:
B017 'assertRaises(Exception)' and 'pytest.raises(Exception)' should be considered evil.This eliminates the complaint.
Again, it is unclear what the best match re is, or the more specific exception trap is.
The last hunk (match="BadLoader") produces the exception:
<ExceptionInfo AttributeError("'BadLoader' object has no attribute 'setup_logging'") tblen=3>The earlier 3 hunks produce exceptions that rep like (differing only in the scheme reported):
<ExceptionInfo LoaderNotFound('Could not find a matching loader for the scheme "file+bad".') tblen=4>I believe that match re-s given are a good representation of the expected error,s but I did the obvious thing and didn't think too deeply.