Pin the link checker to v1 - #227
Conversation
✅ Deploy Preview for sparkly-moxie-de1f0e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for adorable-cucurucho-69162b ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟢 Ready to approve
The change is a straightforward action-version repin with no apparent workflow/YAML issues and aligns with the PR’s stated intent.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the GitHub Actions workflow to use the supported v1 major tag of the QuantEcon link checker action, avoiding the unintended use of a very early v1.0.0 tag that points at the action’s initial commit.
Changes:
- Repin
QuantEcon/action-link-checkerfrom@v1.0.0to@v1in the link-check workflow.
File summaries
| File | Description |
|---|---|
| .github/workflows/linkcheck.yml | Updates the action reference to the maintained v1 major tag for the weekly link-check job. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
linkcheck.ymlpinned the link checker at@v1.0.0, which resolves to890d35e— the action repository's very first commit, from before its test suite, CI workflow and README fixes existed. Nothing errored, because that earlyaction.ymlhappens to accept all five inputs this workflow passes, so the workflow has been silently running pre-release code.Repinned to
@v1, the moving tag created with the v1.1.0 release.That release matters here because this workflow sets
create-issue: 'true'on a weekly cron. Before v1.1.0 every run opened a fresh issue; now a recurring finding refreshes one open issue instead. It also fixes a bug where a timeout on a well-known host was always reported broken — the allowance meant to absorb that could never fire on a timeout, only on a connection error.No findings are outstanding in this repository right now, so this is preventative.
lectures/_config.ymlhas an emptylinkcheck_ignore, so there is nothing to mirror intoignore-patternsyet.