Skip to content

Remove numba dependencies#192

Merged
jstac merged 3 commits into
mainfrom
remove_numba
May 4, 2023
Merged

Remove numba dependencies#192
jstac merged 3 commits into
mainfrom
remove_numba

Conversation

@Smit-create

Copy link
Copy Markdown
Member

@jstac. There were 2 files using numba:

  1. commod_price -- unused import so no harm in removing.
  2. schelling -- just one instance of njit which I replace by using vectorized numpy.

@netlify

netlify Bot commented May 4, 2023

Copy link
Copy Markdown

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 4142cc7
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/645350ed439934000859edcf
😎 Deploy Preview https://deploy-preview-192--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jstac

jstac commented May 4, 2023

Copy link
Copy Markdown
Contributor

Nice work @Smit-create !

Please fix the failing build and then I will merge.

@Smit-create

Copy link
Copy Markdown
Member Author

The CI fails due to http timeout in heavy tails lecture:

df_fs = pd.read_csv('https://media.githubusercontent.com/media/QuantEcon/high_dim_data/update_csdata/cross_section/forbes-global2000.csv')

I have re-run the job to see if that fixes.

@jstac

jstac commented May 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @Smit-create . @shlff is managing that code, in case you need to discuss with him.

@github-actions

github-actions Bot commented May 4, 2023

Copy link
Copy Markdown

@Smit-create
Smit-create requested a review from jstac May 4, 2023 08:24
@jstac

jstac commented May 4, 2023

Copy link
Copy Markdown
Contributor

Perfect, thanks @Smit-create

@jstac
jstac merged commit 0152898 into main May 4, 2023
@jstac
jstac deleted the remove_numba branch May 4, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants