Skip to content

🌐 [translation-sync] FIX: seven source-side defects in python_by_example, functions, numpy and pandas - #29

Open
mmcky wants to merge 6 commits into
mainfrom
translation-sync-2026-08-05T02-43-04-pr-604
Open

🌐 [translation-sync] FIX: seven source-side defects in python_by_example, functions, numpy and pandas#29
mmcky wants to merge 6 commits into
mainfrom
translation-sync-2026-08-05T02-43-04-pr-604

Conversation

@mmcky

@mmcky mmcky commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#604 - FIX: seven source-side defects in python_by_example, functions, numpy and pandas

Files Updated

  • ✏️ lectures/functions.md
  • ✏️ .translate/state/functions.md.yml
  • ✏️ lectures/pandas.md
  • ✏️ .translate/state/pandas.md.yml
  • ✏️ lectures/python_by_example.md
  • ✏️ .translate/state/python_by_example.md.yml

Details

  • Source Language: en
  • Target Language: fr
  • Model: claude-sonnet-5

This PR was created automatically by the translation action.

Copilot AI lite review requested due to automatic review settings August 5, 2026 02:43
@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-08-05
Routing: editor — 1 minor finding(s) in gating categories (accuracy/terminology/syntax/diff-check/other)
Shadow gate: would NOT auto-merge (recorded only; no action taken)


📝 Translation Quality

Criterion Score
Accuracy 9/10
Fluency 9/10
Terminology 9/10
Formatting 10/10
Overall 9.2/10

Summary: The translation of the changed sections is accurate, fluent, and terminologically consistent with the glossary. Minor stylistic issues remain around occasional direct reader address ('vous') that could be rendered more impersonally per the specified academic register, but these do not impede comprehension. No syntax or structural errors were found in the modified sections. Consistent and accurate use of glossary terminology (e.g., 'Loi normale centrée réduite', 'Tirages aléatoires', 'Chaîne de Markov'-style precision maintained elsewhere) Faithful preservation of code blocks, math notation, and MyST directive syntax throughout the changed sections Correct French typography applied (non-breaking spaces before high punctuation, appropriate translation of descriptive symbols like 'aire = π * rayon²') Good restructuring of long English sentences into clearer French ones in the Overview and Random Draws sections

Suggestions:

  • [minor · fluency] lectures/pandas.md — ### Accessing Data with requests: The English 'Assuming that all is working, you can now proceed to build...' is translated as 'En supposant que tout fonctionne, vous pouvez maintenant construire...' — this is acceptable, but per the style policy of avoiding direct reader address in academic register, a more impersonal phrasing could be used, e.g. 'Si tout fonctionne, il est possible de construire...' → Si tout fonctionne correctement, il est possible de construire à présent l'objet source...
  • [minor · fluency] lectures/pandas.md — ### Make Changes in DataFrames: 'La capacité d'effectuer des modifications dans les dataframes est importante...' is a slightly literal rendering of 'The ability to make changes in dataframes is important...'; a more natural French phrasing would flow better. → Pouvoir modifier les dataframes est une étape importante pour générer un jeu de données propre en vue d'analyses futures.
  • [minor · accuracy] lectures/functions.md — ## Recursive Function Calls (Advanced): The English 'This is an advanced topic that you should feel free to skip' has been translated as 'Ceci est un sujet avancé que vous pouvez ignorer sans problème', which uses direct address ('vous'), inconsistent with the style guide's preference for impersonal academic register. → Il s'agit d'un sujet avancé qu'il est possible d'ignorer sans problème.
  • [nit · fluency] lectures/python_by_example.md — ### While Loops: The comment translation 'la condition de fin de la boucle while' is accurate but slightly verbose compared to the concise English '#the ending condition for the while loop'; acceptable as is, minor stylistic note only.

🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 10/10

Summary: Several source code and prose changes (LIFO/FILO wording, isinstance/pd.isna refactors, df.where argument addition) were not propagated to the target document's code cells and text.

Issues:

  • functions.md: Source changed 'First In Last Out (FILO) queue' to 'last-in, first-out (LIFO) data structure' but target still says 'file d'attente First In Last Out (FILO)' - not synced
  • pandas.md: Source code changed 'type(x)!=str' to 'not isinstance(x, str)' in two code cells, but target code cells still contain the old 'type(x)!=str' syntax
  • pandas.md: Source code changed 'np.isnan(x)' to 'pd.isna(x)' but target code cell still contains 'np.isnan(x)'
  • pandas.md: Source changed 'df.where(df.POP >= 20000)' to 'df.where(df.POP >= 20000, False)' but target code cell still shows the old single-argument version

This review was generated automatically by action-translation review mode.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronise la version française avec le correctif source (PR QuantEcon/lecture-python-programming#604) en appliquant plusieurs ajustements de contenu dans les cours (Python par l’exemple, fonctions, pandas) et en mettant à jour les métadonnées de synchronisation de traduction.

Changes:

  • Nettoyage de la mise en forme (suppression de lignes vides parasites, ajustements de ponctuation/inline-code) dans python_by_example.md et functions.md.
  • Corrections d’exemples et de formulation dans pandas.md (notamment where(...) et traitement de valeurs manquantes via pd.isna).
  • Mise à jour des fichiers d’état .translate/state/*.yml (SHA source, date de sync, modèle, version d’outil).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lectures/python_by_example.md Ajustements de mise en forme et clarification de l’explication de la boucle while.
lectures/pandas.md Corrections d’exemples (where/NaN, isinstance, pd.isna) et reformulations associées.
lectures/functions.md Nettoyage de mise en forme et correction de terminologie (LIFO).
.translate/state/python_by_example.md.yml Mise à jour des métadonnées de synchronisation de traduction.
.translate/state/pandas.md.yml Mise à jour des métadonnées de synchronisation de traduction.
.translate/state/functions.md.yml Mise à jour des métadonnées de synchronisation de traduction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


```{code-cell} python3
i == ts_length # la condition de fin de la boucle while
i == ts_length #la condition de fin de la boucle while
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-29--verdant-toffee-3261a8.netlify.app

Commit: b0777cb

📚 Changed Lectures


Build Info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants