Skip to content

[numba]_fix_imports - #116

Closed
shlff wants to merge 1 commit into
masterfrom
nb1
Closed

[numba]_fix_imports#116
shlff wants to merge 1 commit into
masterfrom
nb1

Conversation

@shlff

@shlff shlff commented Dec 6, 2020

Copy link
Copy Markdown
Member

Good morning, @jstac and @mmcky ,

I noticed an issue in lecture numba:

  • the import from numba.experimental import jitclass is not working
  • it returns an error message ModuleNotFoundError: No module named 'numba.experimental'

This PR fixes this issue by replacing

  • the original imports from numba import float64 and from numba.experimental import jitclass
  • with modified imports from numba import float64, jitclass

Do you think it is a good idea?

@shlff
shlff requested a review from mmcky December 6, 2020 23:08
@github-actions
github-actions Bot temporarily deployed to commit December 6, 2020 23:08 Inactive
@jstac

jstac commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Good catch @shlff , nice work.

@mmcky I remember this change was made a few months back. Do you think it's an issue in some of our other lectures that use numba?

@mmcky

mmcky commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

@shlff are you testing this locally? You may want to update your anaconda if so.

It seems to be fine on the live site: https://python-programming.quantecon.org/numba.html

It should be numba.experimental to support future releases of numba

@shlff

shlff commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

Thanks for your comments, @jstac and @mmcky .

As @mmcky suggested, I had this issue because the version of my numba is 0.48.0, while they relocate jitclass between versions 0.48 and 0.49.

Now I upgrade my numba, so this issue has been solved.

I will close this PR.

@shlff shlff closed this Dec 7, 2020
@shlff
shlff deleted the nb1 branch December 7, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants