Conversation
jstac
reviewed
Jan 15, 2021
jstac
reviewed
Jan 15, 2021
| ``` | ||
|
|
||
| However, it's more common and better practice to use NumPy functionality explicitly | ||
| However, it's more common and better practice to use NumPy functionality explicitly. One good feature of Numpy is it has a faster processing time than other Python libraries. |
Contributor
There was a problem hiding this comment.
@Horace510 : The statement you added is not precise enough. Sometimes other libraries are faster. (Also, Numpy should be NumPy.)
Also, the point here is that you can bring in NumPy implicitly, via SciPy, or explicitly. It's better to be explict.
How about adding ", rather than implicitly via SciPy" ?
Contributor
|
Thanks @mmcky , this is good to go. |
jstac
approved these changes
Sep 20, 2021
Contributor
|
thanks @jstac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@shlff @jstac
I added one useful feature of the Numpy to the file, it was one of the suggestions I made in my email.
Thanks!