Some minor typos - #128
Closed
giorgi-tsu wants to merge 6 commits into
Closed
Conversation
I have changed the way the labels are constructed for different alpha values in the legend. In the hint for the exercise 2 you mentioned string concatenation as well as str() function for constructing labels for different alpha values, however in the solution you used f string. So, may be it would be better to show first how string concatenation is sed and then propose f string as an alternative version.
Corrected typo on line 501
Contributor
|
thanks for the PR @giorgi-tsu I will review these soon. |
Contributor
|
thanks @giorgi-tsu I don't agree with all of these changes so I will close this PR and then apply the elements you have highlighted in a separate PR. Thanks for the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found some minor typos and since I support the project wholehartedly, I am trying to correct any typos I find in the notebook.