Skip to content

[pdflatex] Enable book style build of PDF via LaTeX - #139

Merged
mmcky merged 6 commits into
masterfrom
enable-latex-pdf
May 11, 2021
Merged

[pdflatex] Enable book style build of PDF via LaTeX#139
mmcky merged 6 commits into
masterfrom
enable-latex-pdf

Conversation

@mmcky

@mmcky mmcky commented May 6, 2021

Copy link
Copy Markdown
Contributor

This PR brings book style PDF support via LaTeX

@mmcky
mmcky requested a review from AakashGfude May 6, 2021 00:45
@github-actions
github-actions Bot temporarily deployed to commit May 6, 2021 00:48 Inactive
@mmcky

mmcky commented May 6, 2021

Copy link
Copy Markdown
Contributor Author

@AakashGfude this doesn't seem to be picking up that there is a pdf available. How is the name of the file determined? I suspect i also need to update _config.yml

@mmcky

mmcky commented May 6, 2021

Copy link
Copy Markdown
Contributor Author

This is presenting a settings button for the live build launcher. With one option it should just retain the single launch button. I think maybe my _config isn't setup correctly on this either?

Screen Shot 2021-05-06 at 10 57 02 am

@AakashGfude

Copy link
Copy Markdown
Member

This is presenting a settings button for the live build launcher. With one option it should just retain the single launch button. I think maybe my _config isn't setup correctly on this either?

Screen Shot 2021-05-06 at 10 57 02 am

Right @mmcky, we need to put only one launcher in _config. at present it has all of them https://github.com/QuantEcon/lecture-python-programming.myst/blob/master/lectures/_config.yml#L31

@AakashGfude

Copy link
Copy Markdown
Member

@AakashGfude this doesn't seem to be picking up that there is a pdf available. How is the name of the file determined? I suspect i also need to update _config.yml

It gets the name from the latex_documents key.
The reason it is not detecting here is that I am checking for the presence of pdf before showing it. SInce latex is run after HTML in the ci. When building HTML, pdf is not present.
What I did earlier in the test PR was to move the latex build before HTML. https://github.com/QuantEcon/lecture-python.myst/pull/127/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR31

@github-actions
github-actions Bot temporarily deployed to commit May 6, 2021 02:04 Inactive
@mmcky

mmcky commented May 6, 2021

Copy link
Copy Markdown
Contributor Author

Hmm one interesting issue is the cache that I have on github actions. We may need a mechanism to rebuild clean

@github-actions
github-actions Bot temporarily deployed to commit May 6, 2021 02:22 Inactive
@github-actions
github-actions Bot temporarily deployed to commit May 6, 2021 02:33 Inactive
@mmcky

mmcky commented May 6, 2021

Copy link
Copy Markdown
Contributor Author

thanks @AakashGfude this is looking nice. Could you take a look and let me know what you think.

@github-actions
github-actions Bot temporarily deployed to commit May 11, 2021 00:55 Inactive
@mmcky
mmcky merged commit 0229091 into master May 11, 2021
@mmcky
mmcky deleted the enable-latex-pdf branch May 11, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants