Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,18 @@ jobs:
- name: Build Download Notebooks (sphinx-tojupyter)
shell: bash -l {0}
run: |
# This is the FIRST `jb build` in the workflow, and `execute_notebooks: "cache"`
# means only the first build actually executes notebooks — the later HTML build
# reads the cache. So this is the step where a CellExecutionError surfaces, and
# therefore the step that has to gate.
#
# `set -eo pipefail` is required as well as `-W`: `shell: bash -l {0}` is a
# custom shell spec, so GitHub does not inject `-eo pipefail` (it only does
# that for the bare `shell: bash` shorthand). Without it a failing `jb build`
# would be masked by the trailing mkdir/cp, whose exit code becomes the
# step's — and `--keep-going` guarantees the .ipynb files exist for `cp`
Comment on lines +63 to +67
# to succeed on.
set -eo pipefail
jb build lectures --path-output ./ --builder=custom --custom-builder=jupyter -n -W --keep-going
mkdir -p _build/html/_notebooks
cp -u _build/jupyter/*.ipynb _build/html/_notebooks
Expand Down
Loading