Skip to content

[mccall_model] Transfer #195: Updating Iteration Variable - #216

Merged
mmcky merged 3 commits into
mainfrom
emilsavalan/main
Aug 9, 2023
Merged

[mccall_model] Transfer #195: Updating Iteration Variable#216
mmcky merged 3 commits into
mainfrom
emilsavalan/main

Conversation

@mmcky

@mmcky mmcky commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

This is a local version of #195

Emil Savalanlı and others added 2 commits January 22, 2022 10:50
commiting changes from old repo
@github-actions

Copy link
Copy Markdown

@mmcky mmcky changed the title Transfer #195: Updating Iteration Variable [mccall_model] Transfer #195: Updating Iteration Variable Mar 22, 2022
@mmcky

mmcky commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

@jstac this looks good to go now.

@mmcky
mmcky requested a review from jstac March 22, 2022 23:12
@mmcky

mmcky commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

@HumphreyYang can you review this stale PR and confirm that it is still relevant. Thanks.

@HumphreyYang

HumphreyYang commented Aug 9, 2023

Copy link
Copy Markdown
Member

@HumphreyYang can you review this stale PR and confirm that it is still relevant. Thanks.

Many thanks @mmcky, this is still relevant and is a good improvement to the coding style.

I have checked the build and the results are the same.

@mmcky

mmcky commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @HumphreyYang

@mmcky
mmcky merged commit 47eecc5 into main Aug 9, 2023
@mmcky

mmcky commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

thanks @emilsavalan for this contribution. Sorry it has taken so long to merge. It is greatly appreciated.

@mmcky
mmcky deleted the emilsavalan/main branch August 9, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants