Skip to content

[harrison_kreps] Fix tables#30

Merged
mmcky merged 1 commit into
mainfrom
fix-tables
Mar 4, 2021
Merged

[harrison_kreps] Fix tables#30
mmcky merged 1 commit into
mainfrom
fix-tables

Conversation

@mmcky

@mmcky mmcky commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

fixes #29

This PR manually fixes the tables in harrison_kreps lecture due to executablebooks/sphinx-tomyst#90

@mmcky
mmcky requested a review from shlff January 6, 2021 03:38
@github-actions
github-actions Bot temporarily deployed to commit January 6, 2021 03:40 Inactive
@mmcky

mmcky commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

I have added an issue on [quantecon-book-theme] for styling of tables

QuantEcon/quantecon-book-theme#79

@shlff shlff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmcky . Nice work!

The first broken table in lecture harrison_kreps has been fixed (left: the preview of this PR, right: original MYST):
Screen Shot 2021-01-06 at 3 21 33 pm

Its second broken table (in Exercise 1) has not been fixed yet:
Screen Shot 2021-01-06 at 3 22 10 pm

Should we fix the 2nd one in this or another PR?

@mmcky

mmcky commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @shlff not yet -- let's hold off on these manual type changes until we freeze lecture-python for edits as the source.

@mmcky

mmcky commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

Its second broken table (in Exercise 1) has not been fixed yet:

@shlff would you mind fixing the second table and committing to this branch?

@github-actions
github-actions Bot temporarily deployed to commit March 2, 2021 03:37 Inactive
@shlff

shlff commented Mar 2, 2021

Copy link
Copy Markdown
Member

Thanks @mmcky . As you can see from the screenshot of the above lecture preview, the second table has been fixed as well.

Screen Shot 2021-03-02 at 2 40 07 pm

@mmcky

mmcky commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

great - thanks @shlff

@mmcky

mmcky commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

thanks @shlff. Also it is good not to use force push if you don't have to. So make sure you have git pull on a branch to get the latest.

@mmcky
mmcky merged commit 34d721f into main Mar 4, 2021
@mmcky
mmcky deleted the fix-tables branch March 4, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lecture_comparison][harrison_kreps] Markdown Tables are Broken in MyST

2 participants