Skip to content

ENH: Use common file for GPU admonition#333

Closed
mmcky wants to merge 2 commits into
mainfrom
include-jax-note
Closed

ENH: Use common file for GPU admonition#333
mmcky wants to merge 2 commits into
mainfrom
include-jax-note

Conversation

@mmcky

@mmcky mmcky commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

This PR moves the GPU admonition to _admonitions/gpu.md

  • wealth_dyanmics
  • kesten_processes

@jstac do you agree with this approach.

The alternative would be to add a more subtle tag such as in QuantEcon/lecture-python-programming#255 (comment)

fixes QuantEcon/meta#75

@github-actions

github-actions Bot commented Apr 12, 2023

Copy link
Copy Markdown

@mmcky mmcky changed the title ENH: Use file for GPU admonition for single point of reference ENH: Use common file for GPU admonition Apr 12, 2023
@mmcky
mmcky requested a review from jstac April 12, 2023 23:57
@mmcky

mmcky commented Apr 17, 2023

Copy link
Copy Markdown
Contributor Author

@jstac if you think this is a better setup I can merge and update the QE manual.

@jstac

jstac commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

@mmcky Thanks. These lectures are having JAX stripped out so I think it's correct to remove the tag. (I'm not sure why we would want a more subtle one if the JAX code is being removed? Sorry if I've misunderstood.)

@mmcky

mmcky commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

@jstac this is essentially a proof of concept to setup quantecon standard admonitions such as the GPU message for files that make use of the gpu. Indeed -- this is getting migrated to lecture-jax but this is a style question for you -- so we only have one place to update the admonition text that is shared across files.

If you like this style using import I will update our style guide with default locations for _admonitions in lectures.

@jstac

jstac commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

Yes, good plan @mmcky, thanks!

Note that @Smit-create has already removed JAX from one of these lectures though --- see #335

It might be gone from the other one too --- I can't remember.

@mmcky

mmcky commented Apr 20, 2023

Copy link
Copy Markdown
Contributor Author

Roger that. Thanks @jstac

@mmcky mmcky closed this May 9, 2023
@mmcky
mmcky deleted the include-jax-note branch May 9, 2023 02:47
mmcky added a commit that referenced this pull request Nov 23, 2025
mmcky added a commit that referenced this pull request Nov 24, 2025
…#733)

* test: Install theme from PR #333 branch for collapsible stderr warnings feature

* Update to released quantecon-book-theme v0.13.0 from PyPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPU note

2 participants