Closed
Fix: ar1_bayes style guide compliance (JAX Rule #1, Writing Rule #2, Code Rule #4)#594
Conversation
Contributor
|
@HumphreyYang I will try your suggestion re: basing off your branch. |
…Code Rule #4) Co-authored-by: mmcky <8263752+mmcky@users.noreply.github.com>
Member
|
I think this is still basing on the main branch : ) Should we ping copilot within the PR? |
…ility Co-authored-by: mmcky <8263752+mmcky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [ar1_bayes] Review lecture for style-guide compliance
Fix: ar1_bayes style guide compliance (JAX Rule #1, Writing Rule #2, Code Rule #4)
Sep 7, 2025
Contributor
thanks @HumphreyYang -- I will set this up in your PR to see how it goes 👍 Also I have started documenting some observations around these style-guide reviews (QuantEcon/meta#234). I find copilot does a LOT better with specific tasks than a general review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses style guide compliance issues in the
ar1_bayes.mdlecture according to the QuantEcon style guide requirements.Issues Fixed
JAX Rule #1 Violation
Before:
After:
The style guide explicitly states "Do NOT install JAX at the top of lectures" to avoid installing suboptimal
jax[cpu]versions.Writing Rule #2 Violations
Split multiple multi-sentence paragraphs into one-sentence paragraphs as required by "Each paragraph must contain exactly one sentence."
Example before:
Example after:
Code Rule #4 Enhancement
Applied Unicode Greek letters in comments and function parameters while maintaining ASCII variable names for PyMC/NumPyro compatibility:
Before:
After:
Verification
The lecture now fully complies with the QuantEcon style guide while maintaining complete functionality.
Fixes #592.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
intro.quantecon.org/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/ar1_bayes.md --path-output ./ -W --keep-going(dns block)jax.quantecon.org/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/ar1_bayes.md --path-output ./ -W --keep-going(dns block)python-advanced.quantecon.org/usr/share/miniconda/envs/quantecon/bin/python /usr/share/miniconda/envs/quantecon/bin/jb build lectures/ar1_bayes.md --path-output ./ -W --keep-going(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.