Backfill shared assets the sync path does not carry (bibliography + Phillips data file)#203
Merged
Merged
Conversation
The translation sync workflow watches lectures/**/*.md and lectures/_toc.yml, so shared assets referenced *by* lectures never cross from the English source. This edition's bibliography had drifted 70 entries behind upstream, and the gap only surfaces when a newly-synced lecture happens to cite a missing key. PR #202 (the Phillips Curve series) cites 57 keys that were absent here, and lectures/phillips_drifts_volatilities.md loads a data file that raises FileNotFoundError by design when it cannot be found — which then cascades into an undefined-label warning for the figure that cell would have produced. Backfills all 70 missing upstream entries rather than only the 57 this PR needs, so the next sync that adds a citation does not fail the same way, and adds the missing NEWQDATA.csv asset. Additive only: the three target-only keys cited by robust_permanent_income.md and theil_2.md are preserved. Refs QuantEcon/action-translation#117
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR backfills shared, non-lecture assets (bibliography entries and a lecture-specific data file) that the automated translation sync workflow does not copy into lecture-python.zh-cn, preventing strict documentation builds from failing when newly-synced lectures introduce new citations or data dependencies.
Changes:
- Appends a new synced block of BibTeX entries to
lectures/_static/quant-econ.bibto close the drift with upstream. - Adds
lectures/_static/lecture_specific/phillips_drifts_volatilities/NEWQDATA.csvto satisfy the Phillips Curve lecture’s data load path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lectures/_static/quant-econ.bib | Adds a backfilled set of upstream BibTeX entries for citation resolution in strict builds. |
| lectures/_static/lecture_specific/phillips_drifts_volatilities/NEWQDATA.csv | Adds the missing dataset required by the Phillips drifts/volatilities lecture code cells. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmcky
added a commit
that referenced
this pull request
Jul 24, 2026
…#204) pybtex refuses to parse a bibliography containing a repeated key, and this file has carried three of them — GilboaSchmeidler:1989, Whittle_1981 and Whittle_1990 each appear twice, once indented in the main body and once unindented near the end. The two copies of each are byte-identical apart from leading whitespace. The effect is total rather than local: `parse_file` raises `BibliographyDataError: repeated bibliography entry` and no bibliography is built, so *every* {cite} in the edition fails to resolve. That is what the "could not find bibtex key" warnings on #202 actually are — the keys are present in the file, but nothing ever parsed it. The 70 entries backfilled in #203 were correct and could never have taken effect while this stood. Predates #203: the same three duplicates and the same parse error are present at 693aa63, before that PR. Verified: pybtex now parses 480 entries, and all 61 keys the #202 build reported missing resolve, as do the three formerly-duplicated ones. Removes the later copy of each; the earlier copy in the main body is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backfills the shared assets that the translation sync path does not carry across, so that #202 can build and the next sync that adds a citation does not fail the same way.
Why this edition's bibliography drifts
The sync workflow watches
lectures/**/*.mdandlectures/_toc.yml. Assets referenced by lectures — the shared bibliography,_static/lecture_specific/**data files,_admonition/*includes — are outside that set and have never crossed. The drift is invisible until a newly-synced lecture happens to cite something missing, at which point the strict build (-n -W) fails. Tracked upstream as QuantEcon/action-translation#117.As of today this bibliography was 70 entries behind
lecture-python.myst(405 against 472).What #202 exposed
The Phillips Curve series cites 57 keys that were absent here, and
lectures/phillips_drifts_volatilities.mdloads a data file that raisesFileNotFoundErrorby design when it cannot be found:That cell is the one that produces
fig-csdv-inflation-persistence, so its absence also produced anundefined labelwarning for a{numref}1300 lines further down — both the figure definition and the reference are present and correctly translated, and the label was undefined only because the data never arrived.What this PR does
lectures/_static/lecture_specific/phillips_drifts_volatilities/NEWQDATA.csvBackfilling all 70 rather than the 57 required is deliberate: the remaining 13 are the next occurrence of this failure waiting to happen.
Verification
GilboaSchmeidler:1989,Whittle_1981,Whittle_1990, cited byrobust_permanent_income.mdandtheil_2.md) are untouchedNote that this fixes one of the two reasons #202 is red. The other is its
_toc.ymlentry for a lecture the sync run failed to translate — QuantEcon/action-translation#156.🤖 Generated with Claude Code