ENH: Basic generic theme - css, js, tpl - #697
Conversation
| site_title = 'Jupinx Base Theme' | ||
| site_description = '' | ||
| site_keywords = '' | ||
| site_author = '' |
There was a problem hiding this comment.
what is the difference between this and author?
There was a problem hiding this comment.
these should be removed and added to jupyter_ section
| copyright = '2019, Thomas J. Sargent and John Stachurski' | ||
| author = 'Thomas J. Sargent and John Stachurski' | ||
| site_title = 'Jupinx Base Theme' | ||
| site_description = '' |
There was a problem hiding this comment.
should this be = project
|
|
hey @DrDrij do we still need |
|
Template removed @mmcky |
|
thanks @DrDrij is this asset missing in
|
| <ul class="sponsor"> | ||
| <li><a href="http://www.sloan.org/" title="Alfred P. Sloan Foundation"><img src="/_static/sloan_logo.png" alt="Sponsored by the Alfred P. Sloan Foundation"></a></li> | ||
| <li><a href="https://quantecon.org/"><img src="/_static/img/qe-logo.png" width="150"></a></li> | ||
| <li><a href="http://www.sloan.org/" title="Alfred P. Sloan Foundation"><img src="/_static/sloan-logo.png" alt="Sponsored by the Alfred P. Sloan Foundation"></a></li> |
There was a problem hiding this comment.
@DrDrij I think this should be sloan_logo.png with an _ rather than a -
| </div> | ||
| <div class="web-version"> | ||
| <a href="/index_toc.html"> | ||
| <span class="thumb"><img src="/_static/img/py-logo.png"></span> |
There was a problem hiding this comment.
@DrDrij one thought I have had with moving these to the _static folder is that they are not assets that are tracked by sphinx. For example they are not in .. figure or .. image directives. This means they will never be parsed by sphinx and perhaps should remain in the theme folder and copied to static as part of the theme support (as is currently done?). What do you think?
This PR: QuantEcon/sphinxcontrib-jupyter#268 would actually break this setup currently as the static assets contained in the html snippets would never be parsed by sphinx.
|
|
Hi @mmcky, is this still active? Anything I need to do? |
|
this will be implemented in the split of projects #950 |
4 participants
This PR adds a basic theme for editing tasks.