Skip to content

Add optional epsilon vector and keyword arg for error - #113

Merged
kshyatt merged 14 commits into
mainfrom
ksh/svd_trunc
Dec 11, 2025
Merged

Add optional epsilon vector and keyword arg for error#113
kshyatt merged 14 commits into
mainfrom
ksh/svd_trunc

Conversation

@kshyatt

@kshyatt kshyatt commented Dec 10, 2025

Copy link
Copy Markdown
Member

Once this looks good, I'll add the downstream tests

@kshyatt
kshyatt requested a review from lkdvos December 10, 2025 12:18
@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@codecov

codecov Bot commented Dec 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
ext/MatrixAlgebraKitGenericLinearAlgebraExt.jl 95.65% <100.00%> (+0.12%) ⬆️
ext/MatrixAlgebraKitGenericSchurExt.jl 100.00% <100.00%> (ø)
src/implementations/svd.jl 92.54% <100.00%> (+0.26%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/implementations/svd.jl Outdated
Comment thread src/implementations/svd.jl Outdated
kshyatt and others added 2 commits December 11, 2025 12:05
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Comment thread src/implementations/svd.jl Outdated
Comment thread src/implementations/svd.jl Outdated
Comment thread src/implementations/svd.jl Outdated
Comment thread src/implementations/svd.jl Outdated
Comment thread src/implementations/svd.jl Outdated
@Jutho
Jutho enabled auto-merge (squash) December 11, 2025 13:22
@lkdvos

lkdvos commented Dec 11, 2025

Copy link
Copy Markdown
Member

mind if I have a look first?

@lkdvos
lkdvos disabled auto-merge December 11, 2025 13:23
Comment thread src/implementations/svd.jl Outdated
@kshyatt
kshyatt enabled auto-merge (squash) December 11, 2025 14:35
@kshyatt
kshyatt merged commit cf57841 into main Dec 11, 2025
10 checks passed
@kshyatt
kshyatt deleted the ksh/svd_trunc branch December 11, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants